Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Documentation the reason for keras version specifier #958

Merged
merged 1 commit into from
Jun 23, 2022
Merged

docs: Documentation the reason for keras version specifier #958

merged 1 commit into from
Jun 23, 2022

Conversation

frgfm
Copy link
Collaborator

@frgfm frgfm commented Jun 23, 2022

This PR simply adds a reference to the reason behind the keras version specifier.

Any feedback is welcome!

cf #932

@frgfm frgfm added topic: documentation Improvements or additions to documentation topic: build Related to dependencies and build framework: tensorflow Related to TensorFlow backend labels Jun 23, 2022
@frgfm frgfm added this to the 0.5.2 milestone Jun 23, 2022
@frgfm frgfm self-assigned this Jun 23, 2022
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #958 (774ec3d) into main (c681273) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #958   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files         134      134           
  Lines        5539     5539           
=======================================
  Hits         5253     5253           
  Misses        286      286
Flag Coverage Δ
unittests 94.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/transforms/modules/base.py 94.59% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c681273...774ec3d. Read the comment docs.

felixdittrich92
felixdittrich92 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thaaanks :)

@felixdittrich92 felixdittrich92 merged commit b3d2cf4 into main Jun 23, 2022
@github-actions
Copy link

Hey @felixdittrich92 👋
You merged this PR, but it is not correctly labeled. The list of valid labels is available at https://github.com/mindee/doctr/blob/main/.github/verify_pr_labels.py

@frgfm frgfm deleted the dep-ref branch June 25, 2022 09:52
@frgfm frgfm added the type: misc Miscellaneous label Jun 25, 2022
@frgfm frgfm mentioned this pull request Jun 28, 2022
Closed
14 tasks
@felixdittrich92 felixdittrich92 mentioned this pull request Sep 26, 2022
Closed
85 tasks
@felixdittrich92 felixdittrich92 modified the milestones: 0.5.2, 0.6.0 Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixdittrich92 felixdittrich92 felixdittrich92 approved these changes

@charlesmindee charlesmindee Awaiting requested review from charlesmindee

Assignees

@frgfm frgfm

Labels
framework: tensorflow Related to TensorFlow backend topic: build Related to dependencies and build topic: documentation Improvements or additions to documentation type: misc Miscellaneous
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@frgfm @felixdittrich92