Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICDAR2013 dataset integration #662

Merged
merged 37 commits into from
Dec 10, 2021
Merged

ICDAR2013 dataset integration #662

merged 37 commits into from
Dec 10, 2021

Conversation

felixdittrich92
Copy link
Contributor

This PR integrates the ICDAR2013 dataset

Issue:
#587

@felixdittrich92
start synth
e7122a5
@felixdittrich92
cleanup
4fa0aff
@felixdittrich92
Merge branch 'mindee:main' into main
3ffdcc5
@felixdittrich92
start synth
b74f06a
@felixdittrich92
add synthtext
1a661e0
@felixdittrich92
add docu and tests
6270c93
@felixdittrich92
apply code factor suggestions
d74f148
@felixdittrich92
apply changes
9099e95
@felixdittrich92
Merge branch 'mindee:main' into main
23eca0d
@felixdittrich92
clean
7ba31e1
@felixdittrich92
Merge branch 'mindee:main' into main
02a8104
@felixdittrich92
Merge branch 'mindee:main' into main
6955110
@felixdittrich92
Merge branch 'mindee:main' into main
8fbeb30
@felixdittrich92
Merge branch 'mindee:main' into main
7408935
@felixdittrich92
Merge branch 'mindee:main' into main
a2b0fbc
@felixdittrich92
Merge branch 'mindee:main' into main
a9cbd14
@felixdittrich92
Merge branch 'mindee:main' into main
b245443
@felixdittrich92
Merge branch 'mindee:main' into main
0cb2f7b
@felixdittrich92
Merge branch 'mindee:main' into main
743c54a
@felixdittrich92
Merge branch 'mindee:main' into main
1c1cbcb
@felixdittrich92
Merge branch 'mindee:main' into main
cfbd898
@felixdittrich92
Merge branch 'mindee:main' into main
8787f74
@felixdittrich92
Merge branch 'mindee:main' into main
47ed381
@codecov
Copy link

codecov bot commented Nov 30, 2021 •
edited
Loading

Codecov Report

Merging #662 (e2d15f2) into main (6360bde) will decrease coverage by 0.21%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   96.25%   96.04%   -0.22%     
==========================================
  Files         120      124       +4     
  Lines        4591     4649      +58     
==========================================
+ Hits         4419     4465      +46     
- Misses        172      184      +12
Flag Coverage Δ
unittests 96.04% <96.55%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/obj_detection/faster_rcnn/pytorch.py 93.75% <93.75%> (ø)
doctr/datasets/ic13.py 97.29% <97.29%> (ø)
doctr/datasets/__init__.py 100.00% <100.00%> (ø)
doctr/models/obj_detection/__init__.py 100.00% <100.00%> (ø)
doctr/models/obj_detection/faster_rcnn/__init__.py 100.00% <100.00%> (ø)
doctr/models/recognition/predictor/pytorch.py 90.90% <0.00%> (-6.07%) ⬇️
...dels/detection/differentiable_binarization/base.py 89.44% <0.00%> (-3.34%) ⬇️
doctr/models/detection/linknet/base.py 83.16% <0.00%> (-1.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9fbe35...e2d15f2. Read the comment docs.

@fg-mindee fg-mindee added the module: datasets Related to doctr.datasets label Dec 6, 2021
@fg-mindee fg-mindee added this to the 0.6.0 milestone Dec 6, 2021
@fg-mindee fg-mindee self-assigned this Dec 10, 2021
fg-mindee
fg-mindee suggested changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added minor suggestions in comment

doctr/datasets/ic13.py Show resolved Hide resolved
doctr/datasets/ic13.py Outdated Show resolved Hide resolved
doctr/datasets/ic13.py Outdated Show resolved Hide resolved
@fg-mindee fg-mindee mentioned this pull request Dec 10, 2021
Closed
7 tasks
fg-mindee
fg-mindee approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit 9f98c30 into mindee:main Dec 10, 2021
@fg-mindee fg-mindee mentioned this pull request Dec 10, 2021
Closed
13 tasks
@felixdittrich92 felixdittrich92 deleted the icdar2013 branch December 10, 2021 13:33
@fg-mindee fg-mindee added ext: docs Related to docs folder topic: documentation Improvements or additions to documentation type: new feature New feature labels Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fg-mindee fg-mindee fg-mindee approved these changes

Assignees

@fg-mindee fg-mindee

Labels
ext: docs Related to docs folder module: datasets Related to doctr.datasets topic: documentation Improvements or additions to documentation type: new feature New feature
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@felixdittrich92 @fg-mindee