Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed W&B config log #656

Merged
merged 1 commit into from
Nov 29, 2021
Merged

fix: Fixed W&B config log #656

merged 1 commit into from
Nov 29, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR fixes the W&B config in training scripts with TF backend.

Any feedback is welcome!

@fg-mindee fg-mindee added type: bug Something isn't working ext: references Related to references folder framework: tensorflow Related to TensorFlow backend labels Nov 29, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Nov 29, 2021
@fg-mindee fg-mindee self-assigned this Nov 29, 2021
Copy link
Contributor

@jonathanMindee jonathanMindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks!

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #656 (9d9937d) into main (9e5b3a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #656   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files         113      113           
  Lines        4386     4386           
=======================================
  Hits         4213     4213           
  Misses        173      173           
Flag Coverage Δ
unittests 96.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e5b3a7...9d9937d. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@fg-mindee fg-mindee merged commit 1937843 into main Nov 29, 2021
@fg-mindee fg-mindee deleted the ref-fix branch November 29, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder framework: tensorflow Related to TensorFlow backend type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants