Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICDAR2003 dataset integration #653

Merged
merged 26 commits into from
Nov 30, 2021
Merged

ICDAR2003 dataset integration #653

merged 26 commits into from
Nov 30, 2021

Conversation

felixdittrich92
Copy link
Contributor

This PR integrates the ICDAR2003 dataset

Issue:
#587

@codecov
Copy link

codecov bot commented Nov 26, 2021 •
edited
Loading

Codecov Report

Merging #653 (247ef92) into main (1937843) will decrease coverage by 0.01%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
- Coverage   96.07%   96.06%   -0.02%     
==========================================
  Files         113      114       +1     
  Lines        4386     4423      +37     
==========================================
+ Hits         4214     4249      +35     
- Misses        172      174       +2
Flag Coverage Δ
unittests 96.06% <97.29%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/svt.py 97.05% <ø> (ø)
doctr/datasets/ic03.py 97.22% <97.22%> (ø)
doctr/datasets/__init__.py 100.00% <100.00%> (ø)
...dels/detection/differentiable_binarization/base.py 91.30% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1937843...247ef92. Read the comment docs.

@fg-mindee fg-mindee self-requested a review November 29, 2021 22:44
@fg-mindee fg-mindee added the module: datasets Related to doctr.datasets label Nov 29, 2021
@fg-mindee fg-mindee added this to the 0.6.0 milestone Nov 29, 2021
fg-mindee
fg-mindee reviewed Nov 29, 2021
View reviewed changes
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Apart from some naming changes, not much to add 👍

docs/source/datasets.rst Outdated Show resolved Hide resolved
doctr/datasets/__init__.py Outdated Show resolved Hide resolved
doctr/datasets/icdar2003.py Outdated Show resolved Hide resolved
doctr/datasets/icdar2003.py Outdated Show resolved Hide resolved
@fg-mindee fg-mindee self-assigned this Nov 30, 2021
fg-mindee
fg-mindee approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Felix 🙏

@fg-mindee fg-mindee merged commit 1f4ceb6 into mindee:main Nov 30, 2021
@felixdittrich92 felixdittrich92 deleted the ic03 branch November 30, 2021 08:41
@fg-mindee fg-mindee mentioned this pull request Dec 10, 2021
Closed
7 tasks
@fg-mindee fg-mindee added type: new feature New feature ext: docs Related to docs folder ext: tests Related to tests folder labels Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fg-mindee fg-mindee fg-mindee approved these changes

Assignees

@fg-mindee fg-mindee

Labels
ext: docs Related to docs folder ext: tests Related to tests folder module: datasets Related to doctr.datasets type: new feature New feature
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@felixdittrich92 @fg-mindee