fix: Prevents rounding errors in RandomCrop #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fg-mindee
added
type: bug
fg-mindee
changed the title
Codecov Report
@@ Coverage Diff @@
## main #473 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 96 96
Lines 4053 4053
=======================================
Hits 3865 3865
Misses 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In very rare cases, the generated coordinates of the crop from
RandomCropwere out of bounds (negative usually). This PR ensures that proper rounding is used and adds clipping to avoid issues.Any feedback is welcome!