Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added portuguese entry in VOCAB #464

Merged
merged 2 commits into from
Sep 13, 2021
Merged

feat: Added portuguese entry in VOCAB #464

merged 2 commits into from
Sep 13, 2021

Conversation

fmobrj
Copy link
Contributor

@fmobrj fmobrj commented Sep 13, 2021

PR for portuguese entry in Vocab.

@fg-mindee fg-mindee self-assigned this Sep 13, 2021
@fg-mindee fg-mindee added module: datasets Related to doctr.datasets type: enhancement Improvement labels Sep 13, 2021
@fg-mindee fg-mindee added this to the 0.4.0 milestone Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021 •
edited
Loading

Codecov Report

Merging #464 (b2722d7) into main (bcd9f9e) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   95.85%   95.76%   -0.09%     
==========================================
  Files          96       95       -1     
  Lines        3952     3993      +41     
==========================================
+ Hits         3788     3824      +36     
- Misses        164      169       +5
Flag Coverage Δ
unittests 95.76% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/vocabs.py 100.00% <ø> (ø)
doctr/models/_utils.py 91.46% <0.00%> (-1.65%) ⬇️
doctr/utils/geometry.py 98.68% <0.00%> (-1.32%) ⬇️
...dels/detection/differentiable_binarization/base.py 91.35% <0.00%> (-0.62%) ⬇️
doctr/models/core.py 93.84% <0.00%> (-0.28%) ⬇️
doctr/__init__.py 100.00% <0.00%> (ø)
doctr/models/__init__.py 100.00% <0.00%> (ø)
doctr/transforms/functional/pytorch.py 100.00% <0.00%> (ø)
doctr/transforms/functional/tensorflow.py 100.00% <0.00%> (ø)
doctr/models/export.py
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcd9f9e...b2722d7. Read the comment docs.

fg-mindee
fg-mindee suggested changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR 🙏
I added one comment about the vocab, let me know what you think!

doctr/datasets/vocabs.py Outdated Show resolved Hide resolved
@fg-mindee fg-mindee mentioned this pull request Sep 13, 2021
Closed
@fg-mindee fg-mindee linked an issue Sep 13, 2021 that may be closed by this pull request
Vocabs #436
Closed
fg-mindee
fg-mindee approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks!
I'll fix the flake8 check later on 👌

@fg-mindee fg-mindee merged commit 0981866 into mindee:main Sep 13, 2021
@calibretaliation calibretaliation mentioned this pull request Mar 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fg-mindee fg-mindee fg-mindee approved these changes

Assignees

@fg-mindee fg-mindee

Labels
module: datasets Related to doctr.datasets type: enhancement Improvement
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Vocabs
2 participants
@fmobrj @fg-mindee