Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Torch detection preprocessing shape #453

Merged
merged 4 commits into from
Aug 31, 2021
Merged

fix: Torch detection preprocessing shape #453

merged 4 commits into from
Aug 31, 2021

Conversation

charlesmindee
Copy link
Collaborator

This PR fixes the detection predictor preprocessing, the shape is now correct when using torch.

@charlesmindee charlesmindee added type: bug Something isn't working critical High priority module: models Related to doctr.models labels Aug 31, 2021
@charlesmindee charlesmindee added this to the 0.4.0 milestone Aug 31, 2021
@charlesmindee charlesmindee self-assigned this Aug 31, 2021
fg-mindee
fg-mindee approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee added framework: pytorch Related to PyTorch backend topic: text detection Related to the task of text detection labels Aug 31, 2021
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #453 (867ab76) into main (d2fef17) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
- Coverage   95.84%   95.84%   -0.01%     
==========================================
  Files          96       96              
  Lines        3997     3996       -1     
==========================================
- Hits         3831     3830       -1     
  Misses        166      166
Flag Coverage Δ
unittests 95.84% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/detection/zoo.py 100.00% <ø> (ø)
doctr/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2fef17...867ab76. Read the comment docs.

@charlesmindee charlesmindee merged commit b0d554f into main Aug 31, 2021
@charlesmindee charlesmindee deleted the fixq branch August 31, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fg-mindee fg-mindee fg-mindee approved these changes

Assignees

@charlesmindee charlesmindee

Labels
critical High priority framework: pytorch Related to PyTorch backend module: models Related to doctr.models topic: text detection Related to the task of text detection type: bug Something isn't working
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesmindee @fg-mindee