[Fix] Remove image padding after rotation correction with straighten_pages=True
#1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixdittrich92
added
type: bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1731 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 164 164
Lines 7782 7823 +41
=======================================
+ Hits 7502 7542 +40
- Misses 280 281 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Olivier Dulcy <106678676+odulcy-mindee@users.noreply.github.com>
odulcy-mindee
approved these changes
Sep 30, 2024
|
@odulcy-mindee btw the API fails actually (after the numpy 2.0 PR merge) poetry install tf == 2.14 besides numpy 2.0 - which can't work 😅 Should we pin numpy < 2.0 in the api requirements or pyproject.toml for the moment ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Added as standalone function because of possible use later in another case instead of integration into
rotate_imageBefore:
After:
Any feedback is welcome 🤗