Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] Add py.typed #1641

Merged
merged 3 commits into from
Jun 12, 2024
Merged

[mypy] Add py.typed #1641

merged 3 commits into from
Jun 12, 2024

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • Add py.typed to package

@felixdittrich92 felixdittrich92 added topic: build Related to dependencies and build type: code quality Related to code quality labels Jun 10, 2024
@felixdittrich92 felixdittrich92 added this to the 0.9.0 milestone Jun 10, 2024
@felixdittrich92 felixdittrich92 self-assigned this Jun 10, 2024
@felixdittrich92 felixdittrich92 linked an issue Jun 10, 2024 that may be closed by this pull request
Add py.typed to the library #1638
Closed
@felixdittrich92 felixdittrich92 marked this pull request as draft June 10, 2024 14:51
@felixdittrich92 felixdittrich92 removed the request for review from odulcy-mindee June 10, 2024 14:51
@felixdittrich92 felixdittrich92 marked this pull request as ready for review June 11, 2024 04:58
@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (3f8bd01) to head (d8bdd3b).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
+ Coverage   96.37%   96.38%   +0.01%     
==========================================
  Files         164      164              
  Lines        7745     7745              
==========================================
+ Hits         7464     7465       +1     
+ Misses        281      280       -1
Flag Coverage Δ
unittests 96.38% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 merged commit 4d9552b into mindee:main Jun 12, 2024
81 checks passed
@felixdittrich92 felixdittrich92 deleted the py-typed branch June 12, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odulcy-mindee odulcy-mindee odulcy-mindee approved these changes

Assignees

@felixdittrich92 felixdittrich92

Labels
topic: build Related to dependencies and build type: code quality Related to code quality
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Add py.typed to the library
2 participants
@felixdittrich92 @odulcy-mindee