[conda] Fix meta.yaml package function name #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1603 +/- ##
==========================================
- Coverage 96.26% 96.23% -0.03%
==========================================
Files 163 163
Lines 7707 7707
==========================================
- Hits 7419 7417 -2
- Misses 288 290 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@odulcy-mindee not sure why this was working before 😅 But "under the hood" it's saved as |
felixdittrich92
added
type: bug
.conda/meta.yaml
Outdated
Comment on lines
11
to
12
| fn: {{ project.get('name') | replace("-", "_")}}-{{ version }}.tar.gz | ||
| url: ../dist/{{ project.get('name') | replace("-", "_")}}-{{ version }}.tar.gz |
There was a problem hiding this comment.
Does it need an extra space to work properly ?
There was a problem hiding this comment.
Which position do you mean ? ^^ we change python-doctr to python_doctr
There was a problem hiding this comment.
@felixdittrich92 Yeah, that was exactly what I meant, sorry I was not clear. Thank you !
odulcy-mindee
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: