-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update version for minor release #1073
Conversation
1ceaaa6
to
396e6d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest holding this until the actual release ;)
VERSION = os.getenv("BUILD_VERSION", "0.5.2a0") | ||
VERSION = os.getenv("BUILD_VERSION", "0.6.0a0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you intend to release 0.6.0, I suggest doing this after the actual release (otherwise it will mess up dev installations ;))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frgfm i have updated the release tracker i would say we are fine to release as minor 0.6.0
Not only bug fixes we have also some new features in 0.6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's move after the release to 0.7.0a0 (the current state seems to be clean (mostly) related to bugs so i think it is ok)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frgfm @odulcy-mindee a short summary why i think it is more a minor release instead a patch release:
(release tracker 0.5.2 is merged in 0.6.0 tracker and updated)
new features:
- all datasets can now be used also for recognition task (inclusive documentation)
- full integration with HF hub (pushing and loading inclusive documentation)
- updated documentation
- updated project build structure
- integrated language detection
- orientation can now also added to the output
- demo is now also PyTorch compatible
- new classification model ViT (TF and PT)
- new recognition model ViTSTR (TF and PT)
- (experimential - feature which is not completly done) all models can be exported to ONNX up to the logits (only TF mobilenet left for 0.7.0 in fact of breaking change for users)
bug fixes:
- MASTER (TF and PT) refactored & fixed
- SAR (TF and PT) refactored & fixed
- some minor fixes and improvements (easier custom model loading, and so on)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you intend to release 0.6.0, I suggest doing this after the actual release (otherwise it will mess up dev installations ;))
I'm not sure to understand. What would be the problem ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it is correct to increase the number to 0.6.0 before we release and afterwards to 0.7.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we skip 0.5.2 in profit of 0.6.0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep all issues from 0.5.2 tracker are included in 0.6.0 now + new features which was planned for 0.6.0 and are done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okey ! That's fine for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normal flow should be 0.1.0 (features / minor) -> 0.1.1 (bug fixes patch) -> 0.2.0 -> .... (0.5.2 was only planned for the architecture fixes from MASTER (PT + TF) and SAR (PT + TF) and are included in 0.6.0)
Codecov Report
@@ Coverage Diff @@
## main #1073 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 142 142
Lines 6018 6018
=======================================
Hits 5731 5731
Misses 287 287
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@odulcy-mindee ok last one that we can release it as 0.6.0 and set it to 0.7.0a= with the post release PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀
This PR:
🤗
CI will pass after merge #1072