Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codestyle] add black formatting #1028

Merged
merged 5 commits into from
Aug 25, 2022
Merged

[codestyle] add black formatting #1028

merged 5 commits into from
Aug 25, 2022

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Aug 24, 2022 •
edited
Loading

This PR:

  • add test for black formatting
  • update makefile
  • format code (black)

related to:
#957

@felixdittrich92 felixdittrich92 added this to the 0.6.0 milestone Aug 24, 2022
@felixdittrich92 felixdittrich92 self-assigned this Aug 24, 2022
@felixdittrich92 felixdittrich92 added topic: ci Related to CI type: code quality Related to code quality labels Aug 24, 2022
@felixdittrich92 felixdittrich92 marked this pull request as draft August 24, 2022 20:30
@felixdittrich92 felixdittrich92 marked this pull request as ready for review August 24, 2022 20:59
@codecov
Copy link

codecov bot commented Aug 24, 2022 •
edited
Loading

Codecov Report

Merging #1028 (ed9aec7) into main (b6e0f52) will not change coverage.
The diff coverage is 94.19%.

@@           Coverage Diff           @@
##             main    #1028   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         135      135           
  Lines        5590     5590           
=======================================
  Hits         5307     5307           
  Misses        283      283
Flag Coverage Δ
unittests 94.93% <94.19%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/zoo.py 100.00% <ø> (ø)
doctr/models/predictor/base.py 82.08% <50.00%> (ø)
doctr/datasets/mjsynth.py 95.83% <66.66%> (ø)
doctr/file_utils.py 78.72% <66.66%> (ø)
doctr/utils/data.py 88.67% <66.66%> (ø)
doctr/models/detection/linknet/base.py 88.69% <75.00%> (ø)
doctr/models/recognition/master/pytorch.py 93.69% <76.47%> (ø)
doctr/models/factory/hub.py 74.69% <79.41%> (ø)
...dels/detection/differentiable_binarization/base.py 93.52% <80.00%> (ø)
doctr/models/recognition/sar/pytorch.py 97.14% <80.00%> (ø)
... and 88 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

odulcy-mindee
odulcy-mindee reviewed Aug 25, 2022
View reviewed changes
Makefile
@@ -2,12 +2,14 @@
quality:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be nice to add .PHONY on top of this Makefile: https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html

.PHONY: quality style test test-common test-tf test-torch docs-single-version docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree nice idea 👍

@aminemindee
Copy link
Contributor

This PR:

* add test for black formatting

* update makefile

* format code (black)

related to: #957

Yeah great idea to add black 👍

everything seems okay for me 👍

odulcy-mindee
odulcy-mindee approved these changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixdittrich92, LGTM

@felixdittrich92 felixdittrich92 merged commit 8774fed into mindee:main Aug 25, 2022
@felixdittrich92 felixdittrich92 deleted the black-form branch August 25, 2022 08:55
@felixdittrich92 felixdittrich92 mentioned this pull request Sep 26, 2022
Closed
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odulcy-mindee odulcy-mindee odulcy-mindee approved these changes

@aminemindee aminemindee aminemindee approved these changes

@charlesmindee charlesmindee Awaiting requested review from charlesmindee

@frgfm frgfm Awaiting requested review from frgfm

Assignees

@felixdittrich92 felixdittrich92

Labels
topic: ci Related to CI type: code quality Related to code quality
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@felixdittrich92 @aminemindee @odulcy-mindee