Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [2.4] rbac revoke check if there is same privilege in other privilege groups granted #38559

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix: [2.4] rbac revoke check if there is same privilege in other privilege groups granted #38559

merged 1 commit into from
Dec 18, 2024

Conversation

shaoting-huang
Copy link
Contributor

@shaoting-huang shaoting-huang commented Dec 18, 2024 •
edited
Loading

cherry-pick from master: #38558
related: #38557, #37031

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 18, 2024
@shaoting-huang
rbac revoke check with meta
5290f3e 
Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
@yanliang567 yanliang567 added this to the 2.4.18 milestone Dec 18, 2024
@mergify mergify bot added the ci-passed label Dec 18, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.18%. Comparing base (b469999) to head (5290f3e).
Report is 2 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 62.50% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38559      +/-   ##
==========================================
+ Coverage   70.35%   72.18%   +1.82%     
==========================================
  Files        1077     1077              
  Lines      169394   169410      +16     
==========================================
+ Hits       119184   122281    +3097     
+ Misses      45745    42665    -3080     
+ Partials     4465     4464       -1
Files with missing lines Coverage Δ
internal/rootcoord/root_coord.go 87.71% <62.50%> (-0.15%) ⬇️

... and 135 files with indirect coverage changes

@tedxu
Copy link
Contributor

tedxu commented Dec 18, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit d84e4f6 into milvus-io:2.4 Dec 18, 2024
13 of 15 checks passed
@shaoting-huang shaoting-huang mentioned this pull request Dec 19, 2024
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@weiliu1031 weiliu1031

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
2.4.18
Development

Successfully merging this pull request may close these issues.
5 participants
@shaoting-huang @tedxu @sre-ci-robot @weiliu1031 @yanliang567