Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: IndexConfigGenerator comment improvement #37739

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhance: IndexConfigGenerator comment improvement #37739

wants to merge 1 commit into from

Conversation

zhengbuqian
Copy link
Collaborator

improvement comment in IndexConfigGenerator to use full index name; removed trailing space in config file(vs code auto removes trailing spaces when saving, and caused lots of unrelated git changes which is annoying)

this PR doesn't need an issue but using this to pass the check:

issue: #35853

@zhengbuqian
improvement comment in IndexConfigGenerator; removed trailing space i…
210e468 
…n config file

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhengbuqian
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 16, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Nov 16, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 16, 2024

@zhengbuqian

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

@zhengbuqian zhengbuqian changed the title IndexConfigGenerator comment improvement enhance: IndexConfigGenerator comment improvement Nov 16, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Nov 16, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (5a23c80) to head (210e468).
Report is 281 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5a23c80) and HEAD (210e468). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5a23c80) HEAD (210e468)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37739       +/-   ##
===========================================
- Coverage   80.67%   68.91%   -11.77%     
===========================================
  Files        1357      290     -1067     
  Lines      190679    25471   -165208     
===========================================
- Hits       153835    17553   -136282     
+ Misses      31416     7918    -23498     
+ Partials     5428        0     -5428
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.91% <ø> (-0.02%) ⬇️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/segcore/IndexConfigGenerator.cpp 84.61% <ø> (ø)

... and 1075 files with indirect coverage changes

@stale Stale
Copy link

stale bot commented Dec 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees
No one assigned
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines. stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhengbuqian @sre-ci-robot