Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [cherry-pick] Record the nodeID before assigning tasks #36493

Merged
merged 1 commit into from
Sep 28, 2024
Merged

fix: [cherry-pick] Record the nodeID before assigning tasks #36493

merged 1 commit into from
Sep 28, 2024

Conversation

xiaocai2333
Copy link
Contributor

@xiaocai2333 xiaocai2333 commented Sep 25, 2024 •
edited
Loading

issue: #33744

master pr: #36371

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Sep 25, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Sep 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 25, 2024

@xiaocai2333 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 25, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 25, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 25, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Record the nodeID before assigning tasks
03fc467 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@mergify mergify bot added the ci-passed label Sep 25, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.88%. Comparing base (bdc59f3) to head (03fc467).
Report is 11 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datacoord/task_index.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #36493       +/-   ##
===========================================
- Coverage   84.97%   71.88%   -13.10%     
===========================================
  Files         793     1060      +267     
  Lines      115327   139760    +24433     
===========================================
+ Hits        98003   100468     +2465     
- Misses      13035    35009    +21974     
+ Partials     4289     4283        -6
Files with missing lines Coverage Δ
internal/datacoord/analyze_meta.go 100.00% <100.00%> (ø)
internal/datacoord/index_meta.go 95.64% <100.00%> (+0.34%) ⬆️
internal/datacoord/task_analyze.go 87.11% <100.00%> (+0.13%) ⬆️
internal/datacoord/task_scheduler.go 98.29% <100.00%> (ø)
internal/datacoord/task_index.go 86.23% <71.42%> (-0.71%) ⬇️

... and 290 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Sep 28, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6335c8b into milvus-io:2.4 Sep 28, 2024
14 of 15 checks passed
@xiaocai2333 xiaocai2333 deleted the record_nodeID branch November 8, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydrain cydrain Awaiting requested review from cydrain

@sunby sunby Awaiting requested review from sunby

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaocai2333 @czs007 @sre-ci-robot