Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Reset task check interval configuration #36121

Merged
merged 4 commits into from
Sep 10, 2024
Merged

enhance: Reset task check interval configuration #36121

merged 4 commits into from
Sep 10, 2024

Conversation

xiaocai2333
Copy link
Contributor

No description provided.

@xiaocai2333
Reset task check interval configuration
5a1cd41 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 9, 2024
@xiaocai2333
update ci config
d712f05 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added area/test sig/testing size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Sep 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 9, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 9, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (9981795) to head (776e738).
Report is 17 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36121      +/-   ##
==========================================
- Coverage   81.62%   81.62%   -0.01%     
==========================================
  Files        1267     1268       +1     
  Lines      150911   151077     +166     
==========================================
+ Hits       123182   123310     +128     
- Misses      22846    22879      +33     
- Partials     4883     4888       +5
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.28% <100.00%> (ø)

... and 48 files with indirect coverage changes

@xiaocai2333
fix
ba1d64c 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 9, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 10, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaocai2333
update e2e config
776e738 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Sep 10, 2024
@mergify mergify bot added the ci-passed label Sep 10, 2024
@yellow-shine
Copy link
Collaborator

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Sep 10, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b0939fd into milvus-io:master Sep 10, 2024
16 checks passed
chyezh pushed a commit to chyezh/milvus that referenced this pull request Sep 11, 2024
@xiaocai2333 @chyezh
enhance: Reset task check interval configuration (milvus-io#36121)
dee0f50 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 deleted the reset_interval_config branch September 25, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@yellow-shine yellow-shine

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaocai2333 @yellow-shine @czs007 @sre-ci-robot