enhance: Use stats Handler to record request/response size metrics #36107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to milvus-io#36102 This PR use newly added `grpcSizeStatsHandler` to reduce calling `proto.Size` since the request & response size info is recorded by grpc framework. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #36107 +/- ##
==========================================
- Coverage 81.62% 72.63% -8.99%
==========================================
Files 1267 1268 +1
Lines 150911 151034 +123
==========================================
- Hits 123182 109706 -13476
- Misses 22846 36434 +13588
- Partials 4883 4894 +11
|
|
/lgtm |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Sep 9, 2024
…ilvus-io#36107) Related to milvus-io#36102 This PR use newly added `grpcSizeStatsHandler` to reduce calling `proto.Size` since the request & response size info is recorded by grpc framework. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
chyezh
pushed a commit
to chyezh/milvus
that referenced
this pull request
Sep 11, 2024
…ilvus-io#36107) Related to milvus-io#36102 This PR use newly added `grpcSizeStatsHandler` to reduce calling `proto.Size` since the request & response size info is recorded by grpc framework. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Sep 30, 2024
Previous label case broken by milvus-io#36107, this PR make all inbound label using label constants from metrics package. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Sep 30, 2024
Previous label case broken by #36107, this PR make all inbound label using label constants from metrics package. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Sep 30, 2024
Previous label case broken by milvus-io#36107, this PR make all inbound label using label constants from metrics package. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Sep 30, 2024
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Oct 28, 2024
Related to milvus-io#36102 Previous PR milvus-io#36107 add grpc inteceptor to observe rpc stats. Using same strategy, this pr add gin middleware to observer restful v2 rpc stats. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Oct 28, 2024
Related to milvus-io#36102 Previous PR milvus-io#36107 add grpc inteceptor to observe rpc stats. Using same strategy, this pr add gin middleware to observer restful v2 rpc stats. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Oct 29, 2024
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Oct 29, 2024
…s-io#37223) Related to milvus-io#36102 Previous PR milvus-io#36107 add grpc inteceptor to observe rpc stats. Using same strategy, this pr add gin middleware to observer restful v2 rpc stats. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #36102
This PR use newly added
grpcSizeStatsHandlerto reduce callingproto.Sizesince the request & response size info is recorded by grpc framework.