Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set an empty segment if compaction deleted all inserts #36044

Merged
merged 4 commits into from
Sep 9, 2024
Merged

fix: Set an empty segment if compaction deleted all inserts #36044

merged 4 commits into from
Sep 9, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #36038

@XuanYang-cn
fix: Set an empty segment if compaction deleted all inserts
26e872a 
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Sep 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Sep 6, 2024
@XuanYang-cn XuanYang-cn mentioned this pull request Sep 6, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 6, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.60%. Comparing base (a103dd5) to head (b2e6916).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
internal/datanode/compaction/segment_writer.go 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36044      +/-   ##
==========================================
+ Coverage   80.72%   81.60%   +0.88%     
==========================================
  Files        1266     1266              
  Lines      150753   150765      +12     
==========================================
+ Hits       121692   123032    +1340     
+ Misses      24188    22861    -1327     
+ Partials     4873     4872       -1
Files with missing lines Coverage Δ
internal/datanode/compaction/segment_writer.go 79.74% <66.66%> (-0.72%) ⬇️

... and 88 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Sep 6, 2024
sre-ci-robot pushed a commit that referenced this pull request Sep 6, 2024
@XuanYang-cn
fix: Set an empty segment if compaction deleted all inserts (#36045)
6dc7d20 
See also: #36038 
pr: #36044

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@czs007
Copy link
Collaborator

czs007 commented Sep 9, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2687747 into milvus-io:master Sep 9, 2024
15 of 16 checks passed
@XuanYang-cn XuanYang-cn deleted the fix-compact-to-nil-segment branch September 9, 2024 06:23
chyezh pushed a commit to chyezh/milvus that referenced this pull request Sep 11, 2024
@XuanYang-cn @chyezh
fix: Set an empty segment if compaction deleted all inserts (milvus-i…
b955ae8 
…o#36044)

See also: milvus-io#36038

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydrain cydrain Awaiting requested review from cydrain

@sunby sunby Awaiting requested review from sunby

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuanYang-cn @czs007 @sre-ci-robot