Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spawn too many threads #26293

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Fix spawn too many threads #26293

merged 1 commit into from
Aug 11, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Aug 11, 2023

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Aug 11, 2023
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 11, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Aug 11, 2023
@yah01
Fix spawn too many threads
93b0f1c 
- Low the thread pool cap
- Limit CGO calls concurrency

Signed-off-by: yah01 <yah2er0ne@outlook.com>
@yah01 yah01 force-pushed the check-virtual-call branch from 1bf5cbd to 93b0f1c Compare August 11, 2023 08:44
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Aug 11, 2023
@yah01 yah01 changed the title Check virtual call Fix spawn too many threads Aug 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Aug 11, 2023 •
edited
Loading

Codecov Report

Merging #26293 (93b0f1c) into master (9489e14) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26293      +/-   ##
==========================================
+ Coverage   82.61%   82.62%   +0.01%     
==========================================
  Files         812      812              
  Lines      109158   109158              
==========================================
+ Hits        90182    90197      +15     
+ Misses      15841    15830      -11     
+ Partials     3135     3131       -4
Files Changed Coverage Δ
internal/querynodev2/segments/segment_loader.go 72.52% <100.00%> (ø)

... and 15 files with indirect coverage changes

@smellthemoon smellthemoon mentioned this pull request Aug 11, 2023
Closed
1 task
@mergify mergify bot added the ci-passed label Aug 11, 2023
@jiaoew1991
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 48422dd into milvus-io:master Aug 11, 2023
This was referenced Aug 14, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@jiaoew1991 jiaoew1991

Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yah01 @jiaoew1991 @sre-ci-robot