Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize rounding distances, avoid promoting to double #22846

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Optimize rounding distances, avoid promoting to double #22846

merged 1 commit into from
Mar 20, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Mar 20, 2023

/kind improvement
Also disable modernize-use-nodiscard check

@yah01
Optimize rounding distances, avoid promoting to double
b3cdafb 
Signed-off-by: yah01 <yang.cen@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Mar 20, 2023
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 20, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023 •
edited
Loading

Codecov Report

Merging #22846 (b3cdafb) into master (2097471) will decrease coverage by 0.09%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22846      +/-   ##
==========================================
- Coverage   82.01%   81.92%   -0.09%     
==========================================
  Files         719      724       +5     
  Lines       99776    99799      +23     
==========================================
- Hits        81831    81762      -69     
- Misses      14952    15016      +64     
- Partials     2993     3021      +28
Impacted Files Coverage Δ
internal/core/src/index/VectorDiskIndex.cpp 0.00% <0.00%> (ø)
internal/core/src/query/SubSearchResult.h 100.00% <ø> (ø)
internal/core/src/index/VectorMemIndex.cpp 92.85% <100.00%> (ø)
internal/core/src/query/SearchOnSealed.cpp 100.00% <100.00%> (ø)
internal/core/src/query/SubSearchResult.cpp 100.00% <100.00%> (ø)
internal/core/src/segcore/ReduceStructure.h 100.00% <100.00%> (ø)

... and 43 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 20, 2023
congqixia
congqixia approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3202eb0 into milvus-io:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@shengjun1985 shengjun1985 Awaiting requested review from shengjun1985

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yah01 @sre-ci-robot @congqixia