Handle question mark in encoded text #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewispb
commented
Oct 11, 2021
jeremy
reviewed
Oct 11, 2021
jeremy
approved these changes
Oct 20, 2021
| \?\= # literal ?= | ||
| }mix # m is multi-line, i is case-insensitive, x is free-spacing | ||
|
|
||
| FULL_ENCODED_VALUE = %r{ # Identical to ENCODED_VALUE but captures the whole rather than components of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ENCODED_VALUE regex to handle an iso-8859-1 encoded value with a question mark in the middle of the text. This is an example string:
=?iso-8859-1?Q?Hello World?_-_How are you??=I've also refactored the regexes to use the free-spacing option. This lets us comment each line of the regex improving readability.