Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very common source of annoyance and confusion is that
trimesh.load
can return lots of different types (i.e. #2239, etc). This re-factor changes the return types to:trimesh.load -> Geometry
trimesh.load_scene -> Scene
trimesh.load_mesh -> Trimesh
trimesh.load(..., force='mesh')
will be deprecated in favor ofload_mesh
trimesh.load_path -> Path
Path2D
orPath3D
which both inherit but is still a little outside the spirit of "functions should return the same type always." Maybe aforce_dimension
argument could be here.This requires some deprecation notices and careful thinking so I'll leave it open for a while.