Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documention needs to be updated to remove outdated note about Sanic #1365

Closed
catdogmat opened this issue Jul 17, 2024 · 3 comments
Closed

Documention needs to be updated to remove outdated note about Sanic #1365

catdogmat opened this issue Jul 17, 2024 · 3 comments

Comments

@catdogmat
Copy link

Describe the bug
The message below says that the Sanic integration is broken, but the integration works perfect on the lastest version of Sanic.

Note: Due to some backward incompatible changes introduced in recent versions of Sanic, it is currently recommended that a Sanic application is deployed with the ASGI integration instead.

To Reproduce
Steps to reproduce the behavior:

  1. Go to this modules documention
  2. Scroll to the Sanic integration section
  3. The outdated note is on the page

Expected behavior
The note is not there.

Logs
None (as it is a documentation change)

Additional context
Sanic issue (with confirmation that the issue is fixed)
@miguelgrinberg
Copy link
Owner

Do you know which version of Sanic fixed this? They haven't closed the issue and the code looks exactly as wrong as I remember it.

@catdogmat
Copy link
Author

I do not. I've only tested the lastest version but I would be happy to test earlier ones if needed.

@miguelgrinberg
Copy link
Owner

The original problem in Sanic isn't fixed. But it appears a change I've made a few months ago to clean up WebSocket responses has indirectly caused this error response from Sanic to go away. I guess if it works, it works. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miguelgrinberg @catdogmat