Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add ctx.jsonp for cross-domain #2713

Merged
merged 2 commits into from
Feb 9, 2023
Merged

fix: add ctx.jsonp for cross-domain #2713

merged 2 commits into from
Feb 9, 2023

Conversation

echosoar
Copy link
Member

@echosoar echosoar commented Feb 7, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023 •
edited
Loading

Codecov Report

Base: 82.01% // Head: 82.01% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (dbe1ffe) compared to base (cc19ab0).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2713   +/-   ##
=======================================
  Coverage   82.01%   82.01%           
=======================================
  Files         419      419           
  Lines       15021    15049   +28     
  Branches     3562     3568    +6     
=======================================
+ Hits        12320    12343   +23     
- Misses       2451     2456    +5     
  Partials      250      250
Impacted Files Coverage Δ
packages/cross-domain/src/configuration.ts 100.00% <100.00%> (ø)
packages/cross-domain/src/middleware/jsonp.ts 88.09% <100.00%> (+5.95%) ⬆️
packages/validate/src/decorator/valid.ts 81.81% <0.00%> (-18.19%) ⬇️
packages/core/src/decorator/web/paramMapping.ts 87.23% <0.00%> (-5.63%) ⬇️
packages/upload/src/parse.ts 92.74% <0.00%> (-0.81%) ⬇️
packages/validate/src/pipe.ts 100.00% <0.00%> (ø)
packages/faas/src/decorator.ts 100.00% <0.00%> (ø)
packages/bootstrap/src/util.ts 90.32% <0.00%> (+3.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616
Copy link
Member

  • 1、lint 没过
  • 2、英文没改
  • 3、ctx.jsnop 的定义没加

@czy88840616 czy88840616 changed the title fix: ctx.jsonp fix: add ctx.jsonp for cross-domain Feb 9, 2023
@czy88840616 czy88840616 merged commit 7c7349c into main Feb 9, 2023
@czy88840616 czy88840616 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Feb 9, 2023
@czy88840616 czy88840616 deleted the feat/ctx-jsonp branch February 9, 2023 07:24
czy88840616 added a commit that referenced this pull request Feb 22, 2023
@czy88840616
Revert "fix: add ctx.jsonp for cross-domain (#2713)"
7ae1441 
This reverts commit 7c7349c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@echosoar @codecov-commenter @czy88840616