Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inject class when use component by import string #996

Merged
merged 3 commits into from
Apr 17, 2021
Merged

fix: inject class when use component by import string #996

merged 3 commits into from
Apr 17, 2021

Conversation

kurten
Copy link
Contributor

@kurten kurten commented Apr 16, 2021

  • 字符串方式 import 的类加载是后置的，需要前置，在主业务代码load之前，这样就能拿到 meta

@gitpod-io
Copy link

gitpod-io bot commented Apr 16, 2021 •
edited
Loading

@kurten kurten force-pushed the 2.x_fix_component branch from cdf5b51 to a89945d Compare April 17, 2021 01:45
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2021 •
edited
Loading

Codecov Report

Merging #996 (46619b9) into 2.x (bfd8232) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x     #996   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files         212      212           
  Lines        8189     8189           
  Branches     1600     1600           
=======================================
  Hits         7022     7022           
  Misses       1120     1120           
  Partials       47       47
Impacted Files Coverage Δ
packages/core/src/context/midwayContainer.ts 95.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfd8232...46619b9. Read the comment docs.

@czy88840616 czy88840616 changed the title 修复组件通过字符串方式import导致无法自动注入问题 fix: inject class when use component by import string Apr 17, 2021
@czy88840616 czy88840616 merged commit 8bfda7d into 2.x Apr 17, 2021
@czy88840616 czy88840616 deleted the 2.x_fix_component branch April 17, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czy88840616 czy88840616 czy88840616 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurten @codecov-commenter @czy88840616