Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use egg-layer load framework circular reference #730

Merged
merged 5 commits into from
Nov 24, 2020

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented Nov 23, 2020

修复 egg-layer 指定 midway v2框架时的死循环问题。

@gitpod-io
Copy link

gitpod-io bot commented Nov 23, 2020

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #730 (8bf1fa1) into 2.x (685e516) will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x     #730      +/-   ##
==========================================
+ Coverage   86.35%   86.37%   +0.01%     
==========================================
  Files         144      144              
  Lines        5820     5821       +1     
  Branches     1059     1064       +5     
==========================================
+ Hits         5026     5028       +2     
+ Misses        762      761       -1     
  Partials       32       32              
Impacted Files Coverage Δ
packages/web/src/index.ts 100.00% <ø> (ø)
packages/web/src/base.ts 90.62% <80.00%> (-0.96%) ⬇️
packages/web/src/framework.ts 87.83% <0.00%> (+2.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685e516...8bf1fa1. Read the comment docs.

@czy88840616 czy88840616 changed the title fix: loader ignore appInfo fix: use egg-layer load framework circular reference Nov 24, 2020
@czy88840616 czy88840616 merged commit f012d78 into 2.x Nov 24, 2020
@czy88840616 czy88840616 deleted the fix_custom_loader branch November 24, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant