Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lazy get default framework #430

Merged
merged 1 commit into from
Mar 17, 2020
Merged

fix: lazy get default framework #430

merged 1 commit into from
Mar 17, 2020

Conversation

monkindey
Copy link
Contributor

如果使用 @ali/midway 的 test 功能的话，每次执行都会报 warning

image

因为 defaultFramework 每次都立刻执行了

@czy88840616
Copy link
Member

额，是的。。

@czy88840616 czy88840616 self-requested a review March 17, 2020 09:29
@czy88840616 czy88840616 merged commit 140c3df into midwayjs:master Mar 17, 2020
@czy88840616
Copy link
Member

Successfully published:

  • midway-mock@1.18.1
  • midway-schedule@1.18.1
  • midway-web@1.18.1
  • midway@1.18.1

@monkindey monkindey deleted the mock-default-framework branch March 17, 2020 12:06
czy88840616 pushed a commit that referenced this pull request Mar 21, 2020
@monkindey @czy88840616
fix: lazy get default framework (#430)
c8c4b49 
(cherry picked from commit 140c3df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czy88840616 czy88840616 czy88840616 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monkindey @czy88840616