fix: build-tsConfig #393
Merged
fix: build-tsConfig #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #393 +/- ##
==========================================
+ Coverage 86.16% 86.48% +0.31%
==========================================
Files 77 77
Lines 2046 2057 +11
Branches 124 124
==========================================
+ Hits 1763 1779 +16
+ Misses 261 256 -5
Partials 22 22
Continue to review full report at Codecov.
|
legendecas
reviewed
Feb 20, 2020
| const cwd = path.join(__dirname, '../../fixtures/ts-dir-no-config'); | ||
| await builder.run({ | ||
| cwd, | ||
| argv: { |
There was a problem hiding this comment.
命令行参数是 object 的话会如何使用呢？
There was a problem hiding this comment.
命令行只支持传入tsconfig文件路径 (project)
There was a problem hiding this comment.
命令行是不是得判断下，如果是字符串，parse 一下？
czy88840616
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix build-tsConfig