Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove port with other framework #1140

Merged
merged 1 commit into from
Jul 6, 2021
Merged

fix: remove port with other framework #1140

merged 1 commit into from
Jul 6, 2021

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Jul 6, 2021

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #1140 (71a3722) into 2.x (9e0e7e5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x    #1140   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files         222      222           
  Lines        8867     8868    +1     
  Branches     1759     1760    +1     
=======================================
+ Hits         7588     7589    +1     
  Misses       1217     1217           
  Partials       62       62           
Impacted Files Coverage Δ
packages/ws/src/framework.ts 92.30% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0e7e5...71a3722. Read the comment docs.

@czy88840616 czy88840616 merged commit 88fec38 into 2.x Jul 6, 2021
@czy88840616 czy88840616 deleted the fix_ws_port branch July 6, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants