-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: serverless app more method #1034
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #1034 +/- ##
==========================================
- Coverage 85.98% 85.82% -0.16%
==========================================
Files 212 212
Lines 8191 8227 +36
Branches 1601 1557 -44
==========================================
+ Hits 7043 7061 +18
- Misses 1102 1115 +13
- Partials 46 51 +5
Continue to review full report at Codecov.
|
let isAddToTrigger = false; | ||
const { path, method } = func.functionTriggerMetadata; | ||
let methodList = [].concat(method || []); | ||
if (methodList.includes('any') || methodList.includes('all')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里应该拿不到 any 和 all 了。
func.functionTriggerMetadata.method = methodList; | ||
} | ||
// 避免重复路径创建多个trigger | ||
const httpTrigger = allFunc[funcName].events.find(event => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在重复路径会抛错,不可能出现。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改改?
Checklist
npm test
passesAffected core subsystem(s)
Description of change