Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serverless app support serverless dev #1010

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

echosoar
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@echosoar echosoar requested a review from czy88840616 April 23, 2021 07:11
@gitpod-io
Copy link

gitpod-io bot commented Apr 23, 2021

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2021

Codecov Report

Merging #1010 (186d782) into 2.x (5e76090) will decrease coverage by 0.04%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #1010      +/-   ##
==========================================
- Coverage   85.98%   85.93%   -0.05%     
==========================================
  Files         212      212              
  Lines        8191     8200       +9     
  Branches     1601     1604       +3     
==========================================
+ Hits         7043     7047       +4     
- Misses       1102     1105       +3     
- Partials       46       48       +2     
Impacted Files Coverage Δ
...ackages-serverless/serverless-app/src/framework.ts 62.50% <58.33%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e76090...186d782. Read the comment docs.

@czy88840616 czy88840616 merged commit bbeeda5 into 2.x Apr 24, 2021
@czy88840616 czy88840616 deleted the fix/support-serverless-dev branch April 24, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants