Skip to content

code-server launcher should forward --socket-path to the underlying server #6940

Closed
@leifwalsh

Description

There are two things called code-server, I'm not sure how you refer to them internally, but I'll call https://aka.ms/vscode-server-launcher/x86_64-unknown-linux-gnu the launcher and https://update.code.visualstudio.com/commit:b06ae3b2d2dbfe28bca3134cc6be65935cdfea6a/server-linux-x64-web/stable, which that downloads, the server.

The server supports --socket-path, which makes it listen on a unix domain socket, which is great for security. We can use that, and send it traffic through a reverse proxy that terminates authentication in the way we like to do authentication internally. Having the server listen on a localhost TCP port is less secure on shared hosts.

But, the launcher only supports --host and --port, it doesn't know about --socket-path. Could we make the launcher forward the --socket-path argument along for code-server serve-local --socket-path?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

code-serverIssues on the VS Code Server.feature-requestRequest for new features or functionalityverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions