Fix plotly under ES6 import #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanMatthewHuff
requested review from
DonJayamanne,
DavidKutu,
joyceerhl and
rchiodo
rchiodo
approved these changes
May 27, 2021
joyceerhl
approved these changes
May 27, 2021
|
Pushing admin as AzDO all passes. |
|
Thanks Ian! Has this fix been released? |
|
@shug1565 Sorry didn't see your comment before now. Yes, it was released a few days ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/vscode-jupyter#5967
Moving renderers to ES6 import breaks plotly bundle. Using a workaround to string replace and fix up a minified bundle.
Workaround / issue discussion here:
plotly/plotly.js#3518
Tested by building release of extension and copying client_renderer into the jupyter extension out directory.
