Update to latest VSC API #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
requested review from
rchiodo,
IanMatthewHuff,
joyceerhl,
DavidKutu and
greazer
rchiodo
reviewed
Sep 24, 2020
|
|
||
| ReactDOM.render(React.createElement(CellOutput, { mimeType, output }, null), container); | ||
| ReactDOM.render(React.createElement(CellOutput, { mimeType: request.mimeType, output }, null), request.element); |
There was a problem hiding this comment.
Oh no cellOutput is still used. We need the changes made to our rendering code ported as well.
There was a problem hiding this comment.
This file here probably needs some changes to get escaping to work correctly. I'll add an issue
There was a problem hiding this comment.
There was a problem hiding this comment.
I'll create a seprate issue for that.
There was a problem hiding this comment.
@rchiodo I have added an issue for this & made a reference to the original PR you submitted.
IanMatthewHuff
approved these changes
Sep 24, 2020
DavidKutu
approved these changes
Sep 24, 2020
joyceerhl
approved these changes
Sep 24, 2020
DonJayamanne
force-pushed
the
update
branch
from
800af58 to
2d9e02e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to latest API