-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump babel and postcss #179
Conversation
0862826
to
8d11332
Compare
@@ -169,6 +169,7 @@ | |||
"@phosphor/widgets": "^1.9.3", | |||
"@vscode/jupyter-ipywidgets7": "^2.0.1", | |||
"@vscode/jupyter-ipywidgets8": "^1.0.2", | |||
"canvas": "^2.11.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonJayamanne It won't compile if canvas
is still marked as optional on Linux it seems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shoudln't addi it as a dependency
as its definitely not a dependency, perhaps dev dependency,
However from the dependency tree this is not at all used.
Please remove canvas
completely
Its not used, I checked,
I moved it from devDependencies
to optional
in the past, but its never been used.
Perhaps I removed something subsequently that requried canvas, e.g. some tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonJayamanne unfortunately vega depends on canvas
ERROR in ./node_modules/@nteract/any-vega/vg2vl1.js 49651:17-34
Module not found: Error: Can't resolve 'canvas' in '/workspaces/vscode-notebook-renderers/node_modules/@nteract/any-vega'
resolve 'canvas' in '/workspaces/vscode-notebook-renderers/node_modules/@nteract/any-vega'
Parsed request is a module
using description file: /workspaces/vscode-notebook-renderers/node_modules/@nteract/any-vega/package.json (relative path: .)
Field 'browser' doesn't contain a valid alias configuration
resolve as module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, so it was never a dev dependency then.
also thats weird, as its not marked as a dependency at all.
probably used in code but not defined in their package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to fix this in debt week, we do not need the whole canvas package
It compiles native modules.
All we need is just this one simple JS file as everything runs in the browser
https://github.com/Automattic/node-canvas/blob/master/browser.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
& yes, its a dependency thats not defined in their package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove canvas
No description provided.