Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct kb validation for windows ctrl. #80273

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Correct kb validation for windows ctrl. #80273

merged 1 commit into from
Sep 3, 2019

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Sep 3, 2019 •
edited
Loading

Ctrl+Enter is not handled by Find Widget on Windows, the reason for that is we use different key code for Ctrl for macOS and Windows, the right way to check if Ctrl is being pressed is checking

const ctrlKeyMod = (platform.isMacintosh ? KeyMod.WinCtrl : KeyMod.CtrlCmd);

@rebornix rebornix added this to the August 2019 milestone Sep 3, 2019
@sbatten sbatten assigned sbatten and rebornix and unassigned sbatten Sep 3, 2019
@rebornix rebornix merged commit 3db7e09 into release/1.38 Sep 3, 2019
@rebornix rebornix deleted the rebornix/fix-kb-find-win32 branch September 3, 2019 21:16
@rebornix rebornix added the candidate Issue identified as probable candidate for fixing in the next release label Sep 3, 2019
@sbatten sbatten added the verified Verification succeeded label Sep 3, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@rebornix rebornix

Labels
candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
August 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@rebornix @roblourens @sbatten