Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Task Provider resolveTask on grunt extension #76731

Merged
merged 5 commits into from
Aug 5, 2019
Merged

Implement Task Provider resolveTask on grunt extension #76731

merged 5 commits into from
Aug 5, 2019

Conversation

peacemaker14
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented Jul 5, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@peacemaker14 peacemaker14 mentioned this pull request Jul 5, 2019
Closed
@peacemaker14
Copy link
Contributor Author

#76518

hunghw
hunghw reviewed Jul 7, 2019
View reviewed changes
extensions/grunt/src/main.ts Outdated Show resolved Hide resolved
alexr00
alexr00 requested changes Jul 8, 2019
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes, mostly around isEnabled.

extensions/grunt/src/main.ts Outdated Show resolved Hide resolved
extensions/grunt/src/main.ts Outdated Show resolved Hide resolved
extensions/grunt/src/main.ts Outdated Show resolved Hide resolved
extensions/grunt/src/main.ts Outdated Show resolved Hide resolved
@alexr00 alexr00 merged commit d03a91e into microsoft:master Aug 5, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hunghw hunghw hunghw left review comments

@alexr00 alexr00 alexr00 approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peacemaker14 @msftclas @hunghw @alexr00 @bayurrahmadi