Statusbar polishing #52149
Statusbar polishing #52149
Conversation
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| .monaco-workbench > .part.statusbar { | |||
| box-sizing: border-box; | |||
| cursor: default; | |||
There was a problem hiding this comment.
@LeonardoBraga can we just fix it for this particular issue as outlined in #51515 and apply a cursor:default style for the progress message here?
There was a problem hiding this comment.
Definitely. My reasoning behind setting the default cursor style instead of specializing it for each status bar part is that - unless required otherwise - all items in the status bar should not have a "selectable" cursor or a "clickable" one. If you don't agree with this reasoning just let me know and I'll apply the rule directly to the progress items.
There was a problem hiding this comment.
@LeonardoBraga I think the only one that is not working OK right now is the progress one, all the others should get the cursor: default if they are using spans.
There was a problem hiding this comment.
@bpasero unless I'm missing something, in statusbarpart.css, the only selector that sets the cursor to default is .monaco-workbench > .part.statusbar > .statusbar-entry > span, which would not match .statusbar-item and even for .statusbar-entry, it would only match the first level spans.
Besides, having the cursor: default in the selector I suggested would even allow us to remove it from .statusbar-entry > span. Do you still prefer to proceed with the specific selector of the progress item?
There was a problem hiding this comment.
@LeonardoBraga yeah fair enough.
| @@ -134,7 +134,7 @@ class BuildStatusBarItem extends Themable implements IStatusbarItem { | |||
| let callOnDispose: IDisposable[] = []; | |||
|
|
|||
| const element = document.createElement('div'); | |||
| const label = document.createElement('a'); | |||
There was a problem hiding this comment.
@LeonardoBraga this one needs to be an anchor because it is clickable
There was a problem hiding this comment.
My apologies - I missed the click handler in the code right below.
| @@ -290,7 +290,7 @@ class TaskStatusBarItem extends Themable implements IStatusbarItem { | |||
| public render(container: HTMLElement): IDisposable { | |||
|
|
|||
| let callOnDispose: IDisposable[] = []; | |||
| const element = document.createElement('a'); | |||
| const element = document.createElement('span'); | |||
There was a problem hiding this comment.
@LeonardoBraga this one needs to be an anchor because it is clickable
There was a problem hiding this comment.
My apologies - I missed the click handler in the code right below.
LeonardoBraga
force-pushed
the
statusbar-polishing
branch
from
5830ff3 to
1f59e64
Compare
Fixes #51515