Support for middle click to paste selection on Linux #2479
Conversation
|
Hi @Tyriar, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
|
@Tyriar I'm sorry for not giving feedback sooner about this and thank you for showing what is needed to make it work. I used your code to figure out how to use electron's clipboard to get at the special Linux primary clipboard. I didn't merge this because it was a layer-breaker (accessing electron api from a /browser/ folder). We should access electron API only from a /electron-browser/ folder. I know our compilation does not enforce this at this time. IN 0242c3a, I made an editor contribution, and an editor setting that is off by default to enable it. I suggest we leave it disabled by default, gather feedback, and then enable it by default if all is good. |
|
No worries, I didn't have time recently to look at it anyway. So to test on code alpha I use |
|
Yep! Please try it out, I tried only on Ubuntu 14.04.4 |
I hope to make this PR eventually fix #110. Currently it inserts the selection from the clipboard on Linux at the current cursor position. The following needs to be done to the PR:
codeEditorWidget.ts?)MouseHandler?)Any advice on the first two points by people familiar with the code would be greatly appreciated.