-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detailed comment on resolveCustomEditor method documentation #235745
base: main
Are you sure you want to change the base?
Conversation
…ith a small complete example.
@kalebers please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
src/vscode-dts/vscode.d.ts
Outdated
* } | ||
* ``` | ||
*/ | ||
resolveCustomEditor(document: TextDocument, webviewPanel: WebviewPanel, token: CancellationToken): Thenable<void>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having resolveCustomEditor
in the OutputChannel
is wrong. This method is defined and documented here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a new push, just inserting the small example, should be okay now?
Detailed comment in the resolveCustomEditor method, for better documentation