Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server.cli.ts does not await Promises #235738

Merged
merged 1 commit into from
Dec 10, 2024
Merged

server.cli.ts does not await Promises #235738

merged 1 commit into from
Dec 10, 2024
+11 −8

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Dec 10, 2024 •
edited
Loading

Fixes #210034

Includes fixes to run the server-cli from source:

  • run VS Code from source
  • open a Test Resolver window
  • in a console run ./resources/server/bin-dev/remote-cli/code.sh --wait package.json

To verify the changes:

  • open a remote window (WSL, Dev Container)
  • run code-insiders --wait package.json and code-insiders --openExternal package.json

@aeschli aeschli self-assigned this Dec 10, 2024
@aeschli aeschli enabled auto-merge (squash) December 10, 2024 15:13
@aeschli aeschli requested a review from bpasero December 10, 2024 15:13
@vs-code-engineering vs-code-engineering bot added this to the February 2025 milestone Dec 10, 2024
@aeschli aeschli merged commit f43f3cc into main Dec 10, 2024
8 checks passed
@aeschli aeschli deleted the aeschli/xerothermic-pig-805 branch December 10, 2024 16:26
@bhavyaus bhavyaus modified the milestones: February 2025, January 2025 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.

server.cli.ts does not await Promises
3 participants
@aeschli @bpasero @bhavyaus