Add 'open image' context in markdown preview #234649
Conversation
notoriousmango
force-pushed
the
feat-open-image
branch
from
eb2624a to
0b24327
Compare
|
@microsoft-github-policy-service agree |
| @@ -679,6 +686,12 @@ export class DynamicMarkdownPreview extends Disposable implements IManagedMarkdo | |||
| }); | |||
| } | |||
|
|
|||
| openImage(imagePath: string): void { | |||
There was a problem hiding this comment.
Let's move this code into the command. The second argument to vscode.open is a ViewColumn if you need to open in a specific editor group
|
|
||
| public execute(args: { resource: string, imageSource: string }) { | ||
| const source = vscode.Uri.parse(args.resource); | ||
| const { fsPath } = vscode.Uri.parse(args.imageSource); |
There was a problem hiding this comment.
Keep this as a uri. Otherwise it will only work for file: images
There was a problem hiding this comment.
I was thinking the user can only open local images so It should have fsPath. What is other possible options?
There was a problem hiding this comment.
Local in this case would mean part of the workspace, but the workspace could be a virtual file system or a remote machine. Just using fsPath won't work in these cases
|
|
||
| public execute(args: { resource: string; imageSource: string }) { | ||
| const source = vscode.Uri.parse(args.resource); | ||
| const imageSourceUri = vscode.Uri.file(vscode.Uri.parse(args.imageSource).path); |
There was a problem hiding this comment.
You should only need a single call to vscode.Uri.parse. Using vscode.Uri.file again means it will only work if the workspace is on the local file system
If parse isn't enough, try seeing if you can pass the fill string uri to it. It should be something like: file:///path/to/workspace/image.png
| public execute(args: { resource: string; imageSource: string }) { | ||
| const source = vscode.Uri.parse(args.resource); | ||
| const imageSourceUri = vscode.Uri.file(vscode.Uri.parse(args.imageSource).path); | ||
| vscode.commands.executeCommand('vscode.open', imageSourceUri, this._webviewManager.findPreview(source)); |
There was a problem hiding this comment.
findPreview returns a preview which wont be understood by vscode.open. Instead you want to get the view column where the preview is showing. This isn't exposed today but can be accessed from the WebviewPanel stored on a MarkdownPreview.
There was a problem hiding this comment.
I am reusing openDocumentLink. I think It covers what I am trying to do
|
@microsoft-github-policy-service rerun |
resolve #184553
This pull request aims to check whether an
img.srcis local or not, given that a localsrcattribute is automatically changed to a URI internally.I've utilized the fact that any non-local
srcattribute will not be altered, providing a basis for differentiation.I'm open to any suggestions for better ways to achieve this.