Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration tests: colorization test are run 6 times #230380

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Oct 3, 2024

npm run needs -- before script arguments that start with -

e.g. npm run test-extension -- -l vscode-colorize-tests

@aeschli aeschli self-assigned this Oct 3, 2024
@aeschli aeschli enabled auto-merge (squash) October 3, 2024 10:08
@vs-code-engineering vs-code-engineering bot added this to the October 2024 milestone Oct 3, 2024
@aeschli
Copy link
Contributor Author

aeschli commented Oct 3, 2024

@deepak1556 This got introduced by the yarn -> npm migration. yarn didn't require the --

Looking at other places, these could be more candidates of missing --

run: npm run test-browser-no-install --browser chromium

@aeschli
Copy link
Contributor Author

aeschli commented Oct 3, 2024

I also added the -- in vscode/.github/workflows/ci.yml

@aeschli aeschli merged commit f8e51fe into main Oct 3, 2024
8 checks passed
@aeschli aeschli deleted the aeschli/zygomorphic-marmoset-973 branch October 3, 2024 10:34
@deepak1556
Copy link
Collaborator

Oh thanks for catching this!

I adjusted the callsites in the pipeline files https://github.com/microsoft/vscode/tree/main/build/azure-pipelines but missed to check script files 🤦

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants