Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional search path for libc.so.6 in check-requirements-linux.sh #227713

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

henricryden
Copy link
Contributor

check-requirements-linux.sh searches for glibc.so.6, which can be found in /lib64/glibc.so.6 on OpenSUSE 15.4. This PR simply adds that path to be searched.

@deepak1556
Copy link
Collaborator

Thanks for the PR, does the ldconfig condition not resolve to the right libc path on OpenSUSE ? Can you provide a simple repro that is addressed by this PR, thanks!

@henricryden
Copy link
Contributor Author

Thanks for the PR, does the ldconfig condition not resolve to the right libc path on OpenSUSE ? Can you provide a simple repro that is addressed by this PR, thanks!

No problem:
#228094

Copy link
Collaborator

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deepak1556 deepak1556 enabled auto-merge (squash) September 10, 2024 11:11
@deepak1556 deepak1556 added this to the September 2024 milestone Sep 10, 2024
@deepak1556 deepak1556 merged commit 04846aa into microsoft:main Sep 10, 2024
7 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants