Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include editor symbol picks unless symbols are explicitly disabled #216531

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix: include editor symbol picks unless symbols are explicitly disabled #216531

merged 1 commit into from
Jun 18, 2024

Conversation

joyceerhl
Copy link
Collaborator

@joyceerhl joyceerhl commented Jun 18, 2024 •
edited
Loading

Fix #214895

@joyceerhl joyceerhl self-assigned this Jun 18, 2024
@joyceerhl joyceerhl added the candidate Issue identified as probable candidate for fixing in the next release label Jun 18, 2024
@joyceerhl joyceerhl merged commit 5437499 into release/1.90 Jun 18, 2024
7 checks passed
@joyceerhl joyceerhl deleted the dev/joyceerhl/narrow-cuckoo branch June 18, 2024 20:06
@Karliz24 Karliz24 mentioned this pull request Jun 30, 2024
Open
Karliz24
Karliz24 reviewed Jun 30, 2024
View reviewed changes
Copy link

@Karliz24 Karliz24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente

@Karliz24 Karliz24 mentioned this pull request Jul 4, 2024
Open
Ulop pushed a commit to Megaputer/vscode that referenced this pull request Jul 29, 2024
@joyceerhl
fix: include editor symbol picks unless symbols are explicitly disabl…
4dd99dd 
…ed (microsoft#216531)
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Karliz24 Karliz24 Karliz24 left review comments

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees

@joyceerhl joyceerhl

Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joyceerhl @TylerLeonhardt @Karliz24