Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force software gl backend for snap #214548

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

deepak1556
Copy link
Collaborator

Refs #212494

When using the default ANGLE gl/gles backend, v1.90 attempts to get display refresh rate for vsync from an internal implementation instead of using the gl extension EGL_CHROMIUM_sync_control, this eventually ends up loading display info from XRandr and chromium attempts to set a label for the data from the shipped resource pak file that is not accessible to the gpu process triggering a SIGTRAP in ui::ResourceBundle::GetSharedInstance.

Refs #212494

When using the default ANGLE gl/gles backend, v1.90 attempts
to get display refresh rate for vsync from an internal implementation
instead of using the gl extension EGL_CHROMIUM_sync_control,
this eventually ends up loading display info from XRandr and chromium
attempts to set a label for the data from the shipped resource pak
file that is not accessible to the gpu process triggering a SIGTRAP
in ui::ResourceBundle::GetSharedInstance.
@deepak1556 deepak1556 added this to the June 2024 milestone Jun 7, 2024
@deepak1556 deepak1556 self-assigned this Jun 7, 2024
@deepak1556 deepak1556 enabled auto-merge (squash) June 7, 2024 03:51
@deepak1556 deepak1556 merged commit 6e6d380 into main Jun 7, 2024
7 checks passed
@deepak1556 deepak1556 deleted the robo/fix_snap_crash branch June 7, 2024 04:16
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants