fix: deprecate unity-launch flag #209471
Merged
fix: deprecate unity-launch flag #209471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
force-pushed
the
rzhao271/remove-unity-launch
branch
from
1751519 to
cdd47fc
Compare
rzhao271
force-pushed
the
rzhao271/remove-unity-launch
branch
from
cdd47fc to
69dee6d
Compare
|
I have confirmed that Insiders seems to behave the same as the terminal in all instances. |
Tyriar
reviewed
Apr 4, 2024
|
@Tyriar I just confirmed that Code-Insiders still launches and warns that the option is not in the list of known options, but is still passed to Electron/Chromium. |
Tyriar
approved these changes
Apr 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202545
This PR removes mentions of the unity-launch flag.
I have tested the deb and rpm with a custom dev build and found no issues when opening from the launcher with left click or ctrl+left click.
Test opening from the dock with ctrl+left click versus opening a terminal from the dock with ctrl+left click
Test opening from the launcher with ctrl+left click versus opening a terminal from the launcher with ctrl+left click
Test opening from the dock with shift+left click versus opening a terminal from the dock with shift+left click
Test opening from the launcher with shift+left click versus opening a terminal from the launcher with shift+left click