I thought having a separate code-server-linux-legacy.sh without all the check code is much more elegant and less confusing. Why doing all the checks /tmp/vscode-skip-server-requirements-check "$(echo "$@" | grep -c -- "--skip-requirements-check")" -eq 0 ] having the extra file is there's not really any checking going on?

#!/usr/bin/env sh
#
# Copyright (c) Microsoft Corporation. All rights reserved.
#

case "$1" in
	--inspect*) INSPECT="$1"; shift;;
esac

ROOT="$(dirname "$(dirname "$(readlink -f "$0")")")"

"$ROOT/node" ${INSPECT:-} "$ROOT/out/server-main.js" "$@"

just as it was before.

Why doing all the checks /tmp/vscode-skip-server-requirements-check "$(echo "$@" | grep -c -- "--skip-requirements-check")" -eq 0 ] having the extra file is there's not really any checking going on?

We need this for devcontainers, as the extension runs check-requirements.sh directly without going through the server entry script. Then next time when calling the server entry script we want to avoid calling check-requirements.sh again, so the flag --skip-requirements-check was added for it.

/tmp/vscode-skip-server-requirements-check however seems unnecessary here, I can remove that.

Sorry I misunderstood your comment, are you suggesting that extensions should make sure to call the check-requirements.sh before running the server and we remove the script from the server entry point script ?

@chrmarti this PR does 3 things

1. Removes check-requirements.sh from the server entry script. The extension should call the script explicitly before starting the server which I think you already do it for devcontainers. So the flag --skip-requirements-check can be removed
2. Renames asset from legacy-server-linux-* => server-linux-legacy-*
3. Adds a dummy check-requirements.sh as part of the legacy server

Removes check-requirements.sh from the server entry script.

It's still there (for both legacy and normal), but for legacy it doesn't do anything except printing a message.
Not my favourite solution, but good for now. I would polish that next milestone, if that's ok.

It's as Deepak writes, it's gone and now it's up to extensions to call it beforehand.