-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use serverDataFolderName in check-requirements-linux.sh #208074
Conversation
Any reason we want the file to be hidden by default ? I went with |
I think it should be hidden as it's an VS Code internal file. No point for a user to see or manipulate. |
No actually it is the opposite, this file is meant for users to force the legacy server. If the detection script is not returning the right result on a setup for whatever reason we need a way for the users to override the result.
I was thinking the extensions would setup that file depending on the exit code from this script. |
Thinking again, should this rather be a setting on the client side to force the legacy server and avoid introducing a separate file ? That way it works for both classic and exec server cases, also the extension controls the behavior.
|
@deepak1556 Now that
check and leave it to the extensions to have a marker file or a setting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, thanks!
…8074) * Use serverDataFolderName in check-requirements-linux.sh * remove the (new) file check
Instead of serverApplicationName it should be serverDataFolderName