Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update server detection script for legacy server #208000

Merged
merged 2 commits into from
Mar 18, 2024
Merged

chore: update server detection script for legacy server #208000

merged 2 commits into from
Mar 18, 2024

Conversation

deepak1556
Copy link
Collaborator

Refs #206790

@deepak1556 deepak1556 added this to the March 2024 milestone Mar 18, 2024
@deepak1556 deepak1556 requested review from aeschli and chrmarti March 18, 2024 13:00
@deepak1556 deepak1556 self-assigned this Mar 18, 2024
chrmarti
chrmarti previously approved these changes Mar 18, 2024
View reviewed changes
aeschli
aeschli requested changes Mar 18, 2024
View reviewed changes
build/gulpfile.reh.js Outdated Show resolved Hide resolved
resources/server/bin/helpers/check-requirements-linux.sh Outdated Show resolved Hide resolved
@deepak1556 deepak1556 requested a review from aeschli March 18, 2024 14:11
@deepak1556 deepak1556 enabled auto-merge (squash) March 18, 2024 14:26
@deepak1556 deepak1556 merged commit c45557f into main Mar 18, 2024
6 checks passed
@deepak1556 deepak1556 deleted the robo/fix_server_detection_script branch March 18, 2024 15:09
@aeschli
Copy link
Contributor

aeschli commented Mar 19, 2024 •
edited
Loading

Sorry I didn't pay attentiom. It should be serverApplicationName but serverDataFolderName

  • serverDataFolderName is guaranteed to be a valid file/folder name and it matches with the data folder that is already there
  • serverDataFolderName starts with a ., which is IMO what we want.

I create a PR

@aeschli
Copy link
Contributor

aeschli commented Mar 19, 2024

#208074

@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschli aeschli aeschli approved these changes

@chrmarti chrmarti chrmarti left review comments

Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
March 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@deepak1556 @aeschli @chrmarti